feat: add support secret list#73
Merged
Merged
Conversation
gorkarevilla
changed the title
There was a problem hiding this comment.
Pull request overview
Adds support for listing secrets in the VCR CLI by introducing a new vcr secret list subcommand, wiring it into the secret command group, and extending the deployment API/client interface to support a secrets listing endpoint.
Changes:
- Add
vcr secret list(aliasls) command with CLI output for secret names. - Extend
DeploymentInterface+ mocks, and implementDeploymentClient.ListSecrets()againstGET /secrets. - Add unit tests for both the CLI command and the API client.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
vcr/secret/secret.go |
Registers the new list subcommand and updates help text. |
vcr/secret/list/list.go |
Implements the new secret list command and its output. |
vcr/secret/list/list_test.go |
Adds CLI unit tests for the new command. |
pkg/cmdutil/factory.go |
Extends DeploymentInterface with ListSecrets. |
pkg/api/deployment.go |
Implements DeploymentClient.ListSecrets() using the REST endpoint. |
pkg/api/deployment_test.go |
Adds API client unit tests for ListSecrets. |
testutil/mocks/factory.go |
Regenerates mocks to include ListSecrets. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: APIAPEX-2747 add follow flag to instance logs * test: add tests
gorkarevilla
force-pushed
the
APIAPEX-2707/get_secrets
branch
from
f2b0498 to
339e6a1
Compare
gorkarevilla
requested review from
DKVON-prog,
sichan-vonage and
valdemarpereira-vonage
sichan-vonage
approved these changes
May 11, 2026
sichan-vonage
left a comment
sichan-vonage
left a comment
Contributor
There was a problem hiding this comment.
LGTM make sure not to release it before deployment-api has been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
vcr secret listcommand (aliased asvcr secret ls) that displays the names of all secrets stored in a VCR account. Secret values are never exposed.Changes
vcr secret list/vcr secret lsDeploymentClient().ListSecrets()APIExample
When no secrets exist:
The
lsalias also works:Example with smokes accounts (contains lot of secrets):